Skip to content

Apply Sourcery suggestions and fix typos #3131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Apply Sourcery suggestions and fix typos #3131

wants to merge 1 commit into from

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Jun 12, 2025 •
edited
Loading

  • Start applying Sourcery suggestions.
  • Fix typos.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jun 12, 2025
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as draft June 12, 2025 22:14
@dstansby
Copy link
Contributor

I'm 👍 for spelling fixes, and 👎 for refactoring without a linter doing it automatically for us (because it just creates PR review noise for not much technical debt reduction). Could you open a PR to repalce this that just includes the spelling fixes?

@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented Jun 18, 2025 •
edited
Loading

I think Sourcery applies linter rules, but rules that might not be part of ruff (yet). More importantly, I think Sourcery is a good addition - AI assistance for PR review. But I understand you don't agree with it.

Some of the Sourcery suggestions do improve source code are harmful, such as:

-    n_ellipsis = sum(1 for i in selection if i is Ellipsis)
+    n_ellipsis = selection.count(Ellipsis)

How about keeping the couple changes that really make sense?

@DimitriPapadopoulos DimitriPapadopoulos force-pushed the sourcery branch 12 times, most recently from bec6be5 to 7270dd1 Compare June 26, 2025 20:10
@DimitriPapadopoulos DimitriPapadopoulos force-pushed the sourcery branch 3 times, most recently from f55e79a to 5a1df20 Compare July 7, 2025 21:10
@codecov Codecov
Copy link

codecov bot commented Jul 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 94.76%. Comparing base (ea4d7e9) to head (ae772b5).

Files with missing lines Patch % Lines
src/zarr/registry.py 50.00% 3 Missing ⚠️
src/zarr/core/array.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3131   +/-   ##
=======================================
  Coverage   94.76%   94.76%           
=======================================
  Files          78       78           
  Lines        8710     8710           
=======================================
  Hits         8254     8254           
  Misses        456      456
Files with missing lines Coverage Δ
src/zarr/codecs/sharding.py 88.50% <100.00%> (ø)
src/zarr/core/common.py 90.80% <ø> (ø)
src/zarr/core/metadata/v2.py 92.66% <ø> (ø)
src/zarr/core/metadata/v3.py 91.30% <ø> (ø)
src/zarr/testing/stateful.py 98.20% <ø> (ø)
src/zarr/core/array.py 98.52% <0.00%> (ø)
src/zarr/registry.py 88.48% <50.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review July 12, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DimitriPapadopoulos @dstansby